Re: TSVNCache memory leaks

Stefan Fuhrmann wrote:
> Hi there,
>
> some days ago, a coworker had TSVNCache go berserk and
> finally eating 3GB of memory (x64). That gave me sufficient
> motivation to search the code for improper memory management.
>
> r15974 fixes a number of obvious ones and I merged that code
> also into 1.6.x. r15975-7 try to make other parts more robust.
>
> Since TSVNCache is notoriously hard to test, it is very possible
> that I broke something. If you encounter any problem with the
> next nightlies, please tell us.
>
> Stefan, could you review my changes?

Had to change some of your code:
* didn't compile
* had to remove most of the auto_ptr use you introduced because they
threw runtime exceptions
* your 'paranoia' for-loop wouldn't actually do anything?

But due to your changes, I found another bug which I could fix.

Stefan

-- 
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=1469297
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].