log cache bugs

Stefan^2,

I guess these are for you:

http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=1411719

1. build a new folder c:\^svn
2. right click it, select "TortoiseSVN"->"Create repository here"
3. build a new folder c:\WorkCopy
4. right click it, select "SVN Checkout..."
5. use "file:///c:/^svn" as the url, do checkout
6. right click the workcopy folder, select "TortoiseSVN"->"Revision graph"
You will get a crash-report window instead of the graph.

Problem here is that in
CCachedLogInfo* CLogCachePool::GetCache (const CString& uuid, const
CString& root)

the call to
    CRepositoryInfo::SPerRepositoryInfo* info
        = repositoryInfo->data.Lookup (uuid, root);

returns NULL for info (if GetAllowAmbiguousUUID and GetAllowAmbiguousURL
 both return TRUE).

On a side note: I think you have inverted the if-clause there!

Please review my fix for this (r15923)

Another issue is reported here:
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=1416518

I've seen the same issue with the TSVN working copy: showing the log
from the wc root (trunk) worked ok, but the log for /trunk/src or
/trunk/src/TortoiseProc would loop endlessly. The same of course happens
when trying to show the blame for a file inside those subfolders.

Running the log in the debugger shows that the assertion in line 1007 of
the file CacheLogQuery.cpp is hit. And as the comment there tells: it
causes an indefinite loop.

Unfortunately, I cleared the log cache after that to see if that makes a
difference, and it does. But now I don't have the cache anymore :(

I've added a fix in r15928 for this, but I guess you'd rather knew why
that situation occurred in the first place...

Stefan

-- 
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=1418535
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].