Re: time stamps in log window sometimes calculated incorrectly?

Thomas Hemmer wrote:
>> Thomas Hemmer wrote:
>>> Hi all,
>>>
>>> yesterday I faced some oddity regarding the calculation of
>> time values
>>> within the "show log" dialog using a timezone with DST switching.
>>> Assume a log entry having its svn:date property set to
>>> "2008-06-29T19:23:34.171875Z".
>>> Viewing this log entry today yields
>> "2008-06-29T20:23:34.171875Z", not
>>> "2008-06-29T21:23:34.171875Z" as one would expect. During
>> the summer
>>> months it will appear correctly as "2008-06-29T21:23:34.171875Z".
>>> Obviously TSVN determines the time shift dependent on the *current*
>>> DST offset instead of the one due to the date in question.
>>> The svn command line client, in opposition, behaves like I
>> would have
>>> expected.
>>> Since TSVN uses the core SVN client libraries as well I
>> can't figure
>>> why the above mentioned effect happens.
>>>
>>> Does anybody have an idea what I am doing wrong?
>> TSVN always shows you the commit times in your current time zone.
>> Anything else would be misleading. Sure, that means that the
> Hmmm, I can't agree with you on this point (which you might not find
> very surprising ;-) ).
> IMHO we cannot retrospectively refer to a certain point on the time
> scale by using a notation which depends on which offset applies at the
> time of referral - this is exactly what *I* found misleading...
>
>> times are shown differently in summer and winter, but that's
>> the time you're currently referring to and that's what it shows.
>>
>> The problem with the approach you might seem to suggest is
>> that it would show non-linear commits during the 'switch'
>> hour (the hour the DST is changed).
> The SVN folks solved this problem by additionally displaying the time
> offset from UTC.
> Maybe this could be an idea for TSVN, too?
>
> No matter whether or not I managed to convince you, thank you a lot for
> TSVN :-)

Ok, changed in r15630.

Stefan

-- 
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=1304117
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].