2009/2/9 Stefan Fuhrmann <stefanfuhrmann_at_alice-dsl.de>:
> Simon Large <simon.tortoisesvn_at_googlemail.com> wrote:
>
>> A couple of nits with the offline dialog of the log cache. Firstly the
>> text at the top says "there has been a problem connecting the server".
>> That should be "connecting to the server".
>
> As of r15301, it says "contacting". Maybe it should be "reaching"?
We talk about "contacting the repository" in the check for
modifications dialog, so I think that should stay.
>> The meaning of "Don't go offline" is not entirely clear. It could mean
>> cancel or it could mean try again. I suggest using "Retry" or "Try
>> again".
>
> "Don't go offline" is essentially cancel: the operation failed,
> no retries or workarounds will be tried and the initial error
> message will be shown to the user.
Not when I tried it. "Don't go offline" seemed to mean "Retry".
>> There is no cancel option. It may well be that I want the latest info,
>> and if it's not available I may as well give up. None of the 3 options
>> allow me to do that. The quickest way is to "go offline for now", wait
>> for the dialog to finish drawing and then close it.
>
> Because the "Want to go offline?" dialog (now with this new title)
> is used internally in the log cache infrastructure, it is hard to
> affect the calling user dialog. Therefore, there is no simple and
> consistent way to close the log or rev graph dialogs as well.
>
> "Cancel" will seemingly return immediately to the calling dialog
> and show the error. That dialog, in turn, must be closed manually.
> Alternatively, the user may re-establish the server connection
> and retry with F5.
That's fine. Previously none of the buttons would close the "go
offline" dialog immediately with an error message.
>> The buttons are a different shape from anything else in the UI. I know
>> they need space for translations, but the height looks odd, at least
>> with the English text. Not wrong, just inconsistent. How about wider
>> but normal height buttons, in a 2x2 grid (with cancel button, of
>> course :-) like the merge conflicts dialog.
>
> Yuck! I don't see this dialog anymore as my setup is on "auto-pilot".
> Although it is hard to place 3 buttons in a 2x2 grid, I tried my best ;)
I will look at the nightly :-)
Simon
--
: ___
: oo // \\ "De Chelonian Mobile"
: (_,\/ \_/ \ TortoiseSVN
: \ \_/_\_/> The coolest Interface to (Sub)Version Control
: /_/ \_\ http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=1128852
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2009-02-09 13:08:57 CET