Re: Formatting issues in Commit Dialog

Konstantin Kolinko wrote:
>> We have a server-side pre-commit hook that, when fails, outputs a message
>> describing some correct usage. In Tortoise 1.5+ the formatting of the message
>> gets horribly mangled when displayed in the commit dialog. The same message
>> appears much closer to its original, intended, format in earlier versions of Tortoise.
>
> I've reproduced it using TSVN 1.5.5, Build 14361 - 32 Bit on Windows XP SP3
>
> I am attaching sample empty repository (with a hook added) that
> demonstrates the behavior.
>
> To reproduce,
> 1. rename pre-commit._at file in hooks directory to pre-commit.bat
> (GMail did not allow sending it without renaming)
> 2. checkout rev.0 from the repository and try to add a file to it.
>
> Several notes:
> 1. There are two variants of the message in my hooks directory, one
> with LF endings, and another one with CRLF ones. The problem is
> observed if you use the LF one.
>
> If you use the CRLF one, the formatting is OK, but if I use the LF
> one, it goes wild, see attached screenshot.
>
> 2. The message contains empty lines (\n\n in Perl code), but all those
> are missing from "successful" output. The TSVN 1.4.5 picture from OP's
> message shows one empty line.

Thanks for the test repo and script!

Fixed in r14945.

Stefan

-- 
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=992187
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].