Re: Bug at checkout repository

Konstantin Kolinko wrote:
> 2008/12/2 Stefan Kueng <tortoisesvn_at_gmail.com>:
>> ziodraw wrote:
>>> Hi guys,
>>>
>>> I have a very annoying problem with tortoise svn (windows version) release
>>> 1.5.5. If I make a checkout on a repository, the OK Button is disabled in any
>>> case I tested.
>>>
>> This was reported several times now, and every time I'm asking for more
>> information on how to reproduce this (since I still can't reproduce
>> this). As long as no one comes up with a recipe on how I can reproduce
>> this, I can't fix it.
>>
>> So:
>> * what are you doing exactly? I.e., where do you right-click, what menus
>> are you clicking on, which dialogs come up, what paths are you using,
>> what's the url of the repository, what's shown in the checkout dialog
>> * what are your settings in settings->Dialogs 1->Checkout default path/url?
>>
>> btw: you can activate the OK button by modifiying the checkout directory
>> (add a space and remove it again).
>>
>> Stefan
>>
>
> I am able to reproduce the problem.
>
> From the sources: the state of IDOK button is changed only on
> two occasions:
> a) in OnInitDialog,
> that is when dialog initializes
> b) in OnEnChangeCheckoutdirectory,
> that is when you type something in the "Checkout directory" field.
>
> Any other operations that change the checkout directory field
> do not update the button.
>
> To reproduce the problem
> 1. Clear the Checkout directory field, so that the button is disabled.
> 2. Try any of the operations that I list below
>
> 1.Click the "Browse" button for the Repository.path
> and either select a path through the Repository browser,
> or a folder, if the old value there was either empty or was a file:// url.
>
> The checkout directory path is updated, but button is not enabled.
> -> ::OnBnClickedBrowse()
>
> 2. Click the "Browse" button for the Checkout directory and select a folder.
>
> The checkout directory path is updated, but button is not enabled.
> -> ::OnBnClickedCheckoutdirectoryBrowse()
>
> 3. In the Repository path field open the pull-down list
> that offers the paths that you used earlier.
> Select one of those paths.
>
> The checkout directory path is updated, but button is not enabled.
> -> ::OnCbnEditchangeUrlcombo()
>
> It seems that that is all.
>
>> btw: you can activate the OK button by modifiying the checkout directory
>> (add a space and remove it again).
>
> Yes, that enables the button.

Thanks for the analysis!
Fixed in r14790.

Stefan

-- 
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=980721
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].