[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

code in log cache

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Sat, 01 Nov 2008 09:27:24 +0100

Stefan^2,

In LogCacheStatistics.cpp, line 129 there's this method:

size_t CLogCacheStatistics::GetSizeOf (const CCachedLogInfo& container)
{
return GetSizeOf (container.revisions)
         + GetSizeOf (container.logInfo)
         + GetSizeOf (container.skippedRevisions)
         + sizeof (container.fileName)
         + sizeof (container.fileName.capacity() * sizeof (wchar_t))
         + sizeof (container);
}

The statement sizeof (container.fileName.capacity() * sizeof (wchar_t))
seems wrong to me: the outer sizeof() isn't really defined?

If that's really what you wanted, please add a comment to that code so I
don't get confused every time I browse through it :)

Stefan

-- 
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.net

Received on 2008-11-01 09:27:43 CET

This is an archived mail posted to the TortoiseSVN Dev mailing list.