[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Current revision highlight in show log dialog

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Sat, 25 Oct 2008 14:49:45 +0200

Simon Large wrote:
> Hi Stefan,
>
> The highlighting of the current revision doesn't seem to work
> reliably. I have a working copy which is not completely up to date as
> I did some more commits from another PC. For those files that I
> changed on this PC I can see the last commit shown in bold, and on
> some of them it shows that there are later changes made remotely. For
> files not changed on this PC there is no bold emphasis, so I cannot
> tell where the revision the file is updated to sits in the list shown.
> I suspect the test is highlighting the log message when (FileUpdateRev
> == LogMessageRev). However, the revision the file is updated to may
> not be one where a commit was made, so the check should be something
> like (FileUpdateRev >= LogMessageRev && (FileUpdateRev <
> NextLogMessageRev || ThereIsNoNextLogMessage))

The revision used was the revision the item was last updated to. If you
ran an update, that revision is (for a file) usually much higher than
its last committed revision - and that's the revision in the log dialog
that's shown usually on top for a file.

I've changed it now to use the last committed revision, which makes it
work more to what you expect.

Stefan

-- 
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.net

Received on 2008-10-25 14:50:09 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.