[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Patch: fix enable state of statistics dialog pie graph

From: Stefan Fuhrmann <stefanfuhrmann_at_alice-dsl.de>
Date: Tue, 7 Oct 2008 15:33:06 +0200

> Aras Pranckevicius <aras_at_unity3d.com> wrote: 7 Oct 2008 09:54:21 +0300
>
> Log statistics dialog used to disable pie graph type based on number
> of weeks, even if after large amount of weeks the graph turns into
> months and so on. This was somewhat confusing, as after long log
> history the pie graph would be disabled for no apparent reason.
 
> The proper thing would be at least using GetUnitCount() instead of
> m_nWeeks in CStatGraphDlg::OnCbnSelchangeGraphcombo(). However, I
> think what makes most sense is just to enable the pie graph always.
> The worst that can happen is that it will have 14 pies for weeks (at
> 15 weeks it turns into months already). The attached patch does that.
 
Thanks for the patch. This one annoyed me as well
from time to time ;)

Committed as revision 14211.

-- Stefan^2.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_tortoisesvn.tigris.org
For additional commands, e-mail: dev-help_at_tortoisesvn.tigris.org
Received on 2008-10-07 15:32:16 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.