[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: PATCH: Re: TSVNCache process eating all the available CPU

From: Jacques Lemire <Jacques.Lemire_at_gmail.com>
Date: Thu, 3 Jul 2008 05:27:02 -0700 (PDT)

I just tested the nightly build and everything is back to normal + the
bug is fixed. Thank you again.
Jacques

On Jul 2, 1:25 pm, Stefan Küng <tortoise..._at_gmail.com> wrote:
> Jacques Lemire wrote:
> > I noticed you posted my fix on the trunk and merged it on 1.5.x. I see
> > the patch was not applied as is, but was partly done by hand, probably
> > to keep a consistent feel with the rest of the application, which is
> > great. Unfortunately, it was not applied properly and the nightly
> > build is now crashing quite often. The problem is that a line that the
> > patch was supposed to suppress was kept in the file. Here are lines
> > 255-256 of revision 13389 of TSVNPath.cpp in method SanitizeRootPath:
>
> > 255: m_sBackslashPath += '\\';
> > 256: sPath += (bIsForwardPath) ? _T("/") : _T("\\");
>
> > Obviously, line 255 should not be there. You can suppress it from the
> > trunk and safely merge that change to 1.5.x.
>
> Thanks for noticing. I noticed the problem yesterday just after I
> committed the change, but haven't had the time to debug the problem yet.
>
> committed your fix in r13396.
>
> Stefan
>
> --
>         ___
>    oo  // \\      "De Chelonian Mobile"
>   (_,\/ \_/ \     TortoiseSVN
>     \ \_/_\_/>    The coolest Interface to (Sub)Version Control
>     /_/   \_\    http://tortoisesvn.net
>
>  signature.asc
> 1KDownload

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_tortoisesvn.tigris.org
For additional commands, e-mail: dev-help_at_tortoisesvn.tigris.org
Received on 2008-07-03 14:42:27 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.