(Apologies for not replying earlier, I was away on holiday)
> I'm not sure where you got that information from? In the original thread
> there is no indication at all what information Robert sent to the
> WindowBlinds guys, so how do you know they didn't get all the
> information they need?
I'm not the WindowBlinds developer, but I do work for Stardock. I've
read the support ticket on our side. There was no indication that the
user was using non-release versions, nor did the thread above give the
suggestion that anything was different from 1.4.x which might have
prompted them to tell us (ideally, they would have told us anyway, of
course . . . but the world is not ideal).
> > I notice your icon handling code has also been completely overhauled
> > since 1.4.x:
> yes, but what has a complete rewrite to do with this? The rewrite was
> necessary because of Vista.
Correct . . . but as we can see it also affected something on XP.
My point was that the context menu handling code having changed
recently was something that would have been useful to mention. We use
TortoiseSVN ourselves and it was not showing up, exactly because it
was not in "released" code. I had to guess that something had changed
recently, and go and look at it.
> There's a difference between the 1.4.x code and the 1.5 code:
> in 1.4.x, the *whole* menu item was ownerdrawn. That's why we had to do
> a lot more calculations to get the required rectangle for our menu items
> (fonts, string widths, icon sizes, ...).
> In 1.5, only the *icon* is ownerdrawn. The rest of the menu item must be
> drawn by the owner of the menu window. That's why we don't have to
> calculate the rectangle size so complicated.
OK. I did understand that the text was not meant to be drawn in this
situation, I was just not sure that all of the cut measurements or DC
handling were truly unnecessary (especially the assumption that adding
2 to the value currently in the structure was sufficient). If you have
evaluated it and believe this to be OK, then that is fine.
> Now, even though I was sure that this is a WindowBlinds problem, I've
> tried to debug the problem. I wonder if I could charge them for my
> work... ;)
You could try, but would you really want to be paid in worthless
American dollars? ;-)
> First some information you should know:
> * on XP, the styling/theming is active as long as you don't have the
> 'old' win2k look activated. So styling/theming was never the problem.
> Otherwise the icons would have never shown up for the default XP theme
> either.
> * there are two different ownerdraw states of menu items: the whole menu
> item or just the menu icon.
>
> What XP does (correctly):
> * call the shell extension with WM_MEASUREITEM to get the required size
> of the icon to draw
> * WM_MEASUREITEM is *not* called for the whole menu item
> * call the shell extension with WM_DRAWITEM to have the icon drawn
> * shows the menu
>
> And here's what WindowBlinds does:
> * call the shell extension with WM_MEASUREITEM, but it seems it calls to
> get the required size for the whole menu item
> * WM_MEASUREITEM is not called for just the icon
> * it does *not* call the shell extension with WM_DRAWITEM to have the
> icon drawn
> * but it calls the shell extension with WM_DRAWITEM to redraw the whole
> menu item when the menu state changes (active/mouse over, inactive),
> which is just plain wrong!
> * after calling WM_DRAWITEM, it actually *overwrites* the ownerdrawn
> menu with its own drawing before showing the menu.
>
> The last point is only half wrong: it should do that because our menu
> item is only 'icon ownerdrawn' so it *has* to overpaint our own drawing
> with the menu text (which we don't draw ourselves). But apparently it
> also overwrites the part where the icon is located, so even though we
> draw our icon in that case, it never shows up because WindowBlinds
> paints over it...
Thank you for that detailed walkthrough. I will ask the WindowBlinds
developer read your post and see if it is possible to improve our
handling of this situation.
--
Laurence "GreenReaper" Parry
Stardock Development
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_tortoisesvn.tigris.org
For additional commands, e-mail: dev-help_at_tortoisesvn.tigris.org
Received on 2008-05-29 20:57:33 CEST