Re: log cache corruption

Stefan.Fuhrmann_at_etas.com wrote:
> Stefan Küng <tortoisesvn_at_gmail.com> wrote on 05/14/2008 06:43:37 PM:
>
>> We've already got some crash reports for the RC releases where the log
>> cache got corrupted (I've sent you one via PM - the other ones crash for
>
>> the same reason).
>
> Back then I couldn't find the root cause. So I fixed only
> the spot that triggered the crash. (Did you get my reply?)

I don't remember ;)

[snip]
>> So, I propose the following:
>> * before loading the cache file, rename it
>> * load the renamed file
>> * if there's a crash, next time the cache should be loaded it isn't
>> there anymore (only the renamed one which isn't used)
>> * if there's no crash (which should be the default :) ) then after a
>> successful load the file is renamed back

I do the same in the CommitMonitor (and some other of my apps) now. I
think it's much better to only crash once if there's a bug which can
trigger file corruption than to crash always from that time on. Because
if it happens all the time, users can't use the app anymore at all.
If the app only crashes once, I still get (hopefully) the crashreport
but the user can then start working again.

>> This however assumes that no two instances of TortoiseProc access the
>> cache file at the same time.
>
> You time-out commit should be fine for the time being.
> My major concern is about off-line functionality. The way I use
> TSVN, this is one of the most important improvements in 1.5.

I'm not sure, but maybe we should either provide a separate setting for
this or just use a fixed timeout?

> We are speaking of something similar to the "allow ambiguous URLs"
> option but this time it has to work without being noticed :/
>
> Basically, I need some time to think and experiment about it.
> Have been a bit off TSVN lately, so it takes time to speed up ;)

No problem. You have some time until we have to create the 1.5.x branch:
The Subversion guys plan to make yet another RC before the final 1.5
release. I was thinking of branching when they create their next RC.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net