[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Incorrect return value from CHooks::RunScript when CreateProcess fails

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Sat, 19 Apr 2008 09:53:13 +0200

Roger Lipscombe wrote:
> RunScript is supposed to return the exit code from the script. If
> CreateProcess fails, however, it calls SetLastError, and then returns
> FALSE. This is wrong. It should probably return -1, as it does in the
> other failure cases.

Fixed in r12708.

Stefan 

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net

Received on 2008-04-19 09:53:27 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.