[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Feature Request - Allow "add to ignore" on folders marked for addition (but not yet added)

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Sun, 13 Apr 2008 13:32:55 +0200

Thomas S. Trias wrote:
> Example folder structure:
>
> . // top level working directory already added to repository
> .\SubFolder // sub-folder that has not yet been marked for add
> .\SubFolder\ignore.txt // file that I want to ignore
>
> I right click on "." and choose "SVN Add..."
> Within the add dialog, with "SubFolder" checked, I right-click on
> "SubFolder\ignore.txt" and choose "Add to ignore list" > "ignore.txt"
> (which choice is made from the sub-menu is irrelevant).
>
> I get an error dialog: "Could not add ignore.txt to the ignore list!"
> Since there isn't a _svn / .svn folder within SubFolder to store the
> svn:ignore property, this is not unexpected.
>
> However, it would be much handier if this were handled differently; I
> have two thoughts on the matter which I am sure can be argued pro / con
> by people much closer to the source code than I am:
>
> 1) Do a "silent" "svn add" to "SubFolder"
>
> This is probably the easiest fix, but it involves doing something before
> / without explicit confirmation (unless you pop up yet another dialog
> box). This what I end up doing manually by first adding the folder
> structure and then going back and setting svn:ignore properties.

Bad idea! Most users who want to ignore stuff simply don't understand
how the svn:ignore properties work. Silently adding a folder just to
have something ignored will lead to many angry "BUG!!!!" mails here.

> 2) Cache the svn:ignore property for "SubFolder" (and any other folders
> in a similar situation)
>
> Here, TortoiseSVN would keep track of the "svn:ignore" properties for
> folders that have not yet been added; then, when the user chooses "OK",
> TortoiseSVN would first add the folders and then apply the "svn:ignore"
> properties. If someone added to a folder's the ignore list and then
> unchecked the folder, TortoiseSVN could either silently discard the
> svn:ignore property or throw an error trying to set it. This raises the
> additional issue that the add dialog must process ignores both from the
> _svn / .svn information and from the current cache.

Again, adding a folder to version control without the user explicitely
asked for it is a bad idea.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net

Received on 2008-04-13 13:33:12 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.