Kazutoshi Satoda wrote:
> Stefan Küng wrote:
>>>> While that form works for non-UNC paths, it is *not* the default
>>>> form. All Subversion APIs return the form file:/// when asked for URLs.
>>> What API returns the URL for a specific local (including UNC) path?
>>> I couldn't find such a function in svn_client or svn_ra.
>> svn_client_info, and all svn_wc_* functions where the working copy was
>> checked out with the old format.
> They are returning the URL which is stored on the wc. I think they
> are not related to think which form of URL should be the default.
Yes, those return the form of the wc when it was checked out with.
But your patch/change did not just change the 'default' but broke the
handling of those forms completely. We must not abandon the 'old'
format, we must keep supporting it.
>> In know that. But there's a bug which for certain functions *requires*
>> the 'old' format (file:///\hostname/path), where the 'new' format
>> simply doesn't work.
> I have used the new format for years since Subversion 1.2 was
> released. But my wcs with such URL looks working completely.
> Could you please give me a link to the bug or explain what happens
> with the new form?
The new form doesn't properly work with UNC paths. Depending on which
command you use, it sometimes simply doesn't work (in some commands, the
url is parsed wrong, then an URL like file:////server/folder gets split
up into file://, server/folder - and 'server/folder' is *not* a valid path).
I don't remember which functions have that problem, but I remember the
discussion on the mailing list where the final word was that for UNC
paths if the 'new' format doesn't work that users simply could use the
old format. There isn't a reliable way for those commands to find the
local path from the url in all situations (without guessing).
>> Well, I could see that some functions you changed also changed their
>> behavior completely (not just the URL handling).
> I wasn't aware of that. I'm happy if you point out the wrong part.
Check your patch: you sometimes just assume the new format when handling
the urls - the old format would not work anymore.
>> Also some changes in comments really looked like search/replace - they
>> didn't make any sense anymore after your change.
> If you are saying about the comment for IsBDBRepository(), it is
> intended to include support for the new form of the URL for UNC path.
Just accept that your patch doesn't work. You said yourself that you
haven't tested it. And honestly, I don't accept patches which have not
been tested at least a little bit - the biggest part of every change is
the testing, not the implementing. And I'm busy enough as it is.
Let me just say that I checked only the changes to the first two files
of your patch - that was enough for me to see that it simply can't work.
oo // \\ "De Chelonian Mobile"
(_,\/ \_/ \ TortoiseSVN
\ \_/_\_/> The coolest Interface to (Sub)Version Control
/_/ \_\ http://tortoisesvn.net
Received on 2008-03-22 19:55:49 CET