[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r12259 - trunk/src/TortoiseProc/RevisionGraph.cpp

From: <Stefan.Fuhrmann_at_etas.com>
Date: Tue, 4 Mar 2008 14:22:10 +0100

Stefan Küng <tortoisesvn_at_gmail.com> wrote on 04.03.2008 13:47:23:

> > Using GetFirstFileInfo, I mark the last changed revision
> > for single files and folders alike. Usually there is a
> > already a corresponding node in the graph (for obvious
> > reasons). To me, this is an exact description of what
> > "my current position" within the changes graph is.
> The problem is for folders. The last-changed-revisions for folders is
> usually the one where you last changed a property: how often does that
> happen?
> Also, for single-developer projects, you don't run 'update' very often.
> Usually only if you get an out-of-date error on commit due to some
> folder properties changed. In that case, the revision you get for e.g.
> the working copy root folder could be hundreds below the actual revision

> of the working copy.

So, it boils down to mixed revision WCs being the issue.
I find your "one man show" example convincing and will
switch back to GetWCRevisionStatus() asap (maybe tonight).

> > But as long as we don't want to say "mixed revision"
> > in the graph while not marking any revision, I think
> > marking the revision of the selected path is The Right Thing.
> >
> > If you should disagree here, I would rather make it an
> > option to mark the current revision. Some working copies
> > here at the office are more than 10 time as big as TSVN
> > (excluding externals in both cases). Crawling them is
> > a big issue while it isn't for TSVN-sized projects.
> In that case, I'd say we have to go for making this optional. Because
> the folder revision really *is not* the revision the working copy is on
> (otherwise: what's the point of SubWCRev??).

So be it. And while I am at it, I will check what min_rev
in svn_wc_revision_status_t returns. Maybe we can add some
indication to the revivion graph in case of a mixed revision WC.

-- Stefan^2.

To unsubscribe, e-mail: dev-unsubscribe_at_tortoisesvn.tigris.org
For additional commands, e-mail: dev-help_at_tortoisesvn.tigris.org
Received on 2008-03-04 14:22:34 CET

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.