[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Dialog dependencies

From: Alexander Klenin <klenin_at_gmail.com>
Date: Thu, 28 Feb 2008 17:30:09 +1000

On Thu, Feb 28, 2008 at 3:10 AM, Stefan Küng <tortoisesvn_at_gmail.com> wrote:
> > Problem 2:
> > 1) Open log dialog
> > 2) Open TortoiseMerge to show changes in some file
> > 3) Close log dialog
> > 4) Press 'Reload' in TortoiseMerge
> > 5) "Can't open file" error is displayed
> > 5a) (Unrelated bug) OS error message is garbled on non-English
> > Windows, apparently due to incorrect encoding
>
> that's by design: the log dialog removes all temp files on exit. And
> since TortoiseMerge is started with temp files (the ones fetched from
> the repository to do the diff), those are gone once the log dialog closes.
> We could of course change that, but that would mean having temp files
> lying around until the user removes them.

Yes, I know this is not a problem in a sense of "a bug",
but still perhaps it is a design problem.
It is a mere irritation for me, but might be confusing enough
for some user to make him send your favorite "BUG!!!" email ;-)

A most trivial fix is to make error reporting more intelligent:
It should notice somehow (perhaps via additional command-line switch
or by examining file names) that the missing files are TSVN's
temporary files and say something along the lines of
"The parent dialog was closed, please re-open it".

On Wed, Feb 27, 2008 at 3:05 PM, Alexander Klenin <klenin_at_gmail.com> wrote:
> I am not sure how to fix that correctly short of introducing global
> reference counting for dialogs.

More thorough (but much more expensive) fix is as I proposed:
create a global temporary file manager analogous to TSVNCache.

-- 
Alexander S. Klenin
Insight Experts Ltd.
Received on 2008-02-28 08:30:31 CET

This is an archived mail posted to the TortoiseSVN Dev mailing list.