[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Bug Report: Do not need to restart computer after every installation

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Thu, 07 Feb 2008 22:16:08 +0100

Sean Leonard wrote:

> Is this to suggest that comdlg32.dll is loaded by processes running as
> SYSTEM, LOCALSERVICE or NETWORKSERVICE? And thus it is present at the

It *could* be loaded by those, yes.

> winlogon.exe logon prompt? If so then I understand...but I was under the
> impression that winlogon.exe and other system processes do not invoke
> the UI common dialogs.

winlogon does not. But services can.

> Perhaps it is possible to scan (if you are an administrator at least)
> open handles in SYSTEM, LOCALSERVICE and NETWORKSERVICE to the
> TortoiseSVN DLLs (if running with admin privileges) at the end of
> installation, and I suppose that would be out-of-scope for the installer
> code without a lot more engineering effort. But still, I just used

Yes, *way* too much work.

The msi itself checks whether a file is in use when installing and would
prompt for the restart itself if it finds such a file. Problem is: that
doesn't work if a file is in use by an 'invisible' application (e.g.,
the cache or services or any application that doesn't show up on the
taskbar).
That's why I disabled the "files in use" dialog of the msi (you still
get that for the 1.4.x installers, where you're asked to close certain
applications before proceeding).

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net

Received on 2008-02-07 22:16:24 CET

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.