[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Feature request / Bug] Hook script timeout

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Sat, 26 Jan 2008 09:45:47 +0100

Glenn Van Loon wrote:
> Hello,
>
> In this email I would like to request to add functionality to
> TortoiseSVN that can handle time-outs for subversion hook scripts.
>
> I have a cia.vc account for our project (which is hosted on sourceforge)
> and it happens quite often that the cia server is down. As a consequence
> it also happens sometimes that I commit my changes when the cia server
> is down. If this is the case, after the files are committed, the
> tortoise svn commit dialog stays open forever. It only is possible to
> close it by hitting the X (close) button then. After doing so, the
> subversion folder still appears as updated and it is necessary to do an
> "svn update". The update dialog will then "merge" the files on the
> server with the "changed" file in the svn folder, but the updated
> versions are already on the server, so the merge in fact does nothing
> and even though the commit appears as failed, it did succeed.
>
> So I'd like to propose to add a time-out to the commit box, that starts
> after the files are committed.

I'm sorry, but that's not possible to do in TSVN, and also not a good
idea. Because:
* the hook scripts are executed by the svn library. If you really want a
timeout, you have to ask on the svn mailing list for that feature
* what would the timeout be? 1 minute? 2 hours? How would you know what
time your hook script really needs to do the job? Assume you set the
timout to a minute, but the script needs really a minute and one second?

the best way to deal with such issues is to write the hook script so
that it either times out itself, or that it starts a separate process
and returns immediately.
In your case, that means opening an issue on sourceforge and tell the sf
guys to write a better script.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_tortoisesvn.tigris.org
For additional commands, e-mail: dev-help_at_tortoisesvn.tigris.org
Received on 2008-01-26 09:46:05 CET

This is an archived mail posted to the TortoiseSVN Dev mailing list.