[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Log cache recent enhancements

From: <Stefan.Fuhrmann_at_etas.com>
Date: 2007-12-11 01:23:07 CET

Stefan Küng <tortoisesvn@gmail.com> wrote on 10.12.2007 20:11:28:

> Stefan.Fuhrmann@etas.com wrote:
>
> >> The log dialog should indicate whether it is working in online or
> > offline mode.
> >
> > Hm. I am not sure how and when to switch the display.
> > Maybe Stefan can have a look at it?
>
> Can you please have a look ar r11568?
> I'm trying to change the log dialog title according to the state, but
> IsOffline() doesn't seem to work as I would expect it to. With the
> change I made in r11568, it now returns 'offline' when the user set so
> in the registry (without that, it would always return 'online', no
> matter what).
> But: if you change the settings back to "ask the user", it still returns

> 'offline' until you hit F5 in the log dialog.

I think with revisions r11576 through r11579, I got it about right now.
At least I tried all kinds of combinations to and fro.

Sorry that I had to revert r11568. The global setting is used only to
virtually "click" the respective button in the "go offline?" dialog.
Proper implementation of IsOffline() is critical as it will also
handle cases of repositories disconnecting while already receiving logs.

-- Stefan^2.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Tue Dec 11 07:20:26 2007

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.