[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: TMerge editing

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: 2007-10-27 16:59:02 CEST

Alexander Klenin wrote:
> On 10/27/07, Simon Large <simon.tortoisesvn@googlemail.com> wrote:
>> There is some strange behaviour in TMerge in the latest nightly.
>> Insert chars somewhere in the right pane. Use Ctrl-Z to undo, and the
>> pane scrolls so that the active line is right at the bottom of the
>> screen.
> I am looking into these issues now, but they are not very easy to fix.
> There are several entangled problems, and I will need Stefan's help to
> resolve them.
> In particular, Stefan, the bug as cited above is caused by
> pView->DocumentUpdated()
> call in CUndo::Undo function.
> I would replace that call by some other, less destructive function
> (basically just last
> 4-5 lines of DocumentUpdated), but the fact that it is a virtual
> function worries me.
> What was the reason to make it virtual? I can not find any overrides
> in inherited classes,
> but may be I am not looking good enough?

Making a method virtual doesn't imply that there has to be an override
for it :)
That method is virtual so that the left/right/bottom view classes *can*
override it completely if necessary, but until now, that isn't used.


   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Sat Oct 27 16:59:22 2007

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.