[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: log dialog and scintilla control

From: Alexander Klenin <klenin_at_gmail.com>
Date: 2007-10-27 13:22:01 CEST

On 10/27/07, Stefan Küng <tortoisesvn@gmail.com> wrote:
> The log dialog now uses the scintilla control to show the log messages.
> But as you might have seen on this list, it doesn't work properly with
> non-ASCII chars.
> As I recall, your reason for using the scintilla control was to later
> implement the 'edit log message' directly in that control, without the
> need for a separate dialog. But that's a small feature compared to
> having the control showing all chars correctly.
> So what do you think: should we maybe revert back to using the rich edit
> control for showing the log messages?

Oops, I was catching up on my mail and noticed issue change before this message,
so already replied there. However, I will repeat my arguments here to
simplify further discussion.

We could do the revert, yes, but it would be pity.
Using scintilla resulted in a lot of unification and duplicate code removal.
So I would really like to investigate the issue first.
As I already said, I use Russian characters in log messages every day,
and have not had any problem with them.
So this bug seems to be specific to Korean (Asian?) languages.
I think that the bug is generally worth fixing, even if only
for the fact that is should definitely apply to the current 'Edit log
message' dialog too.

On 10/27/07, Stefan Küng <tortoisesvn@gmail.com> wrote:
> Simon Large wrote:
>> How does that work? The commit dialog uses the Scintilla control to
>> write the log message, so why can't it display?
> It has to do with unicode normalization and the different precomposed
> states unicode can have.

Hm. How did you get this info?
Can you give me a sample of exact byte sequence which reproduce this?
With that, I am willing to at least try to find a fix before falling
back to the old code.

> I'd rather write my own control which is *fully* unicode aware (scintilla is not).
It is a whole lot of work.
It looks like scintilla team works on Unicode support, e.g. the message
"Unicode support extended to all Unicode characters not just the Basic
Multilingual Plane."
in the last release noted sounds encouraging ;-)

Alexander S. Klenin
Insight Experts Ltd.
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Sat Oct 27 13:22:07 2007

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.