[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: log dialog and scintilla control

From: Stefan KŁng <tortoisesvn_at_gmail.com>
Date: 2007-10-26 18:24:03 CEST

Simon Large wrote:
> On 26/10/2007, Stefan KŁng <tortoisesvn@gmail.com> wrote:
>> Alexander,
>>
>> The log dialog now uses the scintilla control to show the log messages.
>> But as you might have seen on this list, it doesn't work properly with
>> non-ASCII chars.
>> As I recall, your reason for using the scintilla control was to later
>> implement the 'edit log message' directly in that control, without the
>> need for a separate dialog. But that's a small feature compared to
>> having the control showing all chars correctly.
>> So what do you think: should we maybe revert back to using the rich edit
>> control for showing the log messages?
>
> How does that work? The commit dialog uses the Scintilla control to
> write the log message, so why can't it display?

It has to do with unicode normalization and the different precomposed
states unicode can have.

Also, it's very unlikely that someone *entering* such characters doesn't
have the proper locales set and the fonts installed. But showing those
in the log dialog can happen with people who don't have that set up
because they usually don't need that.

I would have to hack Scintilla a *lot* so it would first split a string
into its glyphs, then draw each glyph separately. Sure, I could do that,
but honestly I'd rather write my own control which is *fully* unicode
aware (scintilla is not).

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Fri Oct 26 18:24:22 2007

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.