[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Proposal: Undo add

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: 2007-10-26 15:43:47 CEST

Simon Large wrote:

> That's a good thought too. If files/folders marked for Add are missing
> at commit time they show up in the commit dialog as missing, but it is
> not obvious what to do next. If you tick the box to enable them for
> commit then they are silently reverted at commit time. That's a useful
> behaviour, but the implementation seems counter-intuitive. The context
> menu offers 'Revert', which I think could be 'Undo add', and 'delete'
> which also does the job, but generates an error message when it tries
> to delete the non-existent file. The 'Delete' context menu entry
> doesn't really make sense for a missing item.

In trunk, the 'Delete' is only shown for files/folders with status
'normal' or 'ignored'.

> How about silently reverting added files which are missing, and remove
> them from the commit list. There is no data loss because the files
> don't exist anyway. If the files really should be added, the result is
> no worse than if you forgot to add it in the first place.

That's not a good idea. The commit dialog has to show that these files
are missing, because the files might be missing accidentally - meaning
the user didn't delete the files but maybe they got deleted by some
build script. The user must be made aware of that fact - after all, he
wanted to *add* the file, but now it's missing. That means that
something didn't work as expected.


   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Fri Oct 26 15:44:09 2007

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.