[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Keyboard shortcuts in log

From: Stefan KŁng <tortoisesvn_at_gmail.com>
Date: 2007-10-24 19:49:23 CEST

Kloster Oddvar wrote:
> Here's a new version of my patch for navigating history from the logdlg
> using the keyboard only. The requested changes have been incorporated.
> I've had little time to devote to this - hence the tortoise speed :)
>
> Summary:
> * When the log dlg opens, focus starts in the rev list. You can do diff
> from prev on the selected revision by pressing Enter. If the log is for
> a file, or only one file was changed in this revision, you get a file
> diff directly, otherwise a Changed Files dlg.
> * Double-clicking on a revision has the same effect. This is disabled by
> default but can be enabled from Settings | Dialogs 1.
> * In the Changed Files dlg, focus starts in the file list. You can
> compare revisions by pressing Enter (as well as the old
> double-clicking).
>
> Bugs:
> * Pressing Enter does not work as intended - the NM_RETURN message is
> either not generated or not caught properly. Instead, pressing Enter
> invokes OnOk.

Thanks a lot for the patch. Committed in revision 11111 (no joke, it's
really 11111).

I had to change your patch a little bit:
* the NM_RETURN message doesn't get sent for dialogs :( So I caught the
return key in the PretranslateMessage() handler instead.
* Don't resize the settings pages! They all have the same size, because
otherwise the biggest one 'wins' to determine the dialog size and all
others look bad.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Wed Oct 24 19:49:46 2007

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.