[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH/RFC] Replace RichEdit with Scintilla in log dialog

From: Alexander Klenin <klenin_at_gmail.com>
Date: 2007-10-17 19:04:56 CEST

Attached (unfinished) patch has following goals:

1) Remove duplicated functionality like
CAppUtils::FormatTextInRichEditControl / CAppUtils::FindStyleChars,
since it is already implemented in SciEdit.

2) Ultimately, allow to edit log message directly from log dialog,
without the need for 'Edit log message' context menu.

3) This, in turn, would allow to remove InputDlg, since it is used
(almost) only here.

It is not complete yet, because:
1) There is a small regression -- URL auto-recognition is lost.
It must be re-implemented using custom regexp in SciEdit.
I will do that, but it will require some time.

2) Cleanup is not finished -- some old code should be deleted.

3) There is no way to save edited log message -- this of course will
be added too.

However, the change is already rather intrusive, so I am posting this
to ask for opinions:
1) Is it a good idea? I obviously think that it is ;-)
2) Should I file an issue?
3) Should I create a branch, or is above-mentioned temporary
regression in trunk acceptable?

Alexander S. Klenin
Insight Experts Ltd.

To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org

Received on Wed Oct 17 19:05:10 2007

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.