[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Enhancement for the issue tracker integration

From: Mark Phippard <markphip_at_gmail.com>
Date: 2007-10-12 23:17:04 CEST

On 10/12/07, Stefan Küng <tortoisesvn@gmail.com> wrote:
> Mark Phippard wrote:
> > On 10/12/07, Stefan Küng <tortoisesvn@gmail.com> wrote:
> >> Subversion 1.5 has the ability to set revision properties with every
> >> commit (and other commands which create a new revision). I thought we
> >> could use this new feature to add a revision property for those who want
> >> it. Of course, it is also possible to get that revision property when
> >> fetching the log information with SVN 1.5, so it will still be possible
> >> to show the associated bug ID with every log message.
> >>
> >> I've already written a proposal on how this could be done:
> >> http://issues.tortoisesvn.net/index.php?do=details&task_id=405
> >>
> >> Please comment on this now so we can get the specs right and can
> >> implement them before SVN 1.5 gets released.
> >
> > Do we still think this is worth doing? Way back when, the reason I
> > thought this would be good is because I imagined being able to ask
> > Subversion questions like "which revisions reference issue 123?"
> > There is still no way to do that ... and probably won't be.
> You're right, there's no way to answer the question "which revisions
> reference issue 123". But issuetrackers which have direct access to the
> repository can modifiy or read revision properties much easier than log
> messages (no need to parse them).

True. I suspect most have gone the hook script route though, where
they store this in the issue tracker. The performance wouldn't scale
to get it from SVN.

> > On the plus side, it makes things easier for people writing hook
> > scripts that want this information.
> And don't forget: the log message itself won't have to be modified (it
> still can be, of course).

Do you mean if the issue needs to be changed/added? I see this as a
downside if the two become out of synch. This is kind of what I am
getting at by doing users a favor by not supporting this.

> > Having used the feature now for so long, the log messages feels like
> > it is the right solution. Especially since command line users and
> > clients that do not implement the feature can so easily participate.
> > I think when you introduced the regex stuff, it really solidified that
> > the log message was the right way to do this.
> >
> > I think we might be doing users a favor by not supporting an option like this.
> How about not making it an option but simply always set that property?
> That way, there's no need for additional configuration for the user, but
> the revision property will always be there and can be used by those who
> need it.
> It shouldn't be too much work to implement this: we already know the
> issue IDs from the log message the user entered, and adding the revision
> property to the ctx structure before commits should be easy enough.

I'll ultimately do my best to support what you decide. Subclipse
might not get this until 1.6 though as none of these API's are exposed
via JavaHL and I think the clock has pretty much run out on getting
some of this (in terms of JavaHL). I think that is OK though, as you
have often had features ahead of us for a release.

Mark Phippard
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Fri Oct 12 23:40:44 2007

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.