Re: Feature Request: remove file extensions when autocompleting in comments

On 28/09/2007, Alexander Klenin <klenin@gmail.com> wrote:
> On 9/27/07, Tobias Schäfer <tobiasschaefer@gmx.de> wrote:
> > On Wednesday 26 September 2007 08:49:27 Alexander Klenin wrote:
> > > On 9/21/07, Philip Thompson <philalanthompson@googlemail.com> wrote:
> > > > When entering a commit comment it would be nice when you type a file
> > > > name for the extension to be removed. I think it just makes the comment
> > > > cleaner.
> [skip]
> > > 1) Include file name with extension in autocompletion list (current
> > > implementation)
> > > 2) Include file name without extension in autocompletion list (as
> > > proposed) 3) Include file name both with and without extension (more
> > > general, but perhaps too much clutter in the list)
> > > 4) Make it configurable (but options are bad)
> [skip]
> > I prefer (1), but wouldn't mind (4) with a hidden registry key. The default
> > should be (1).
> Ok, added AutocompletionRemovesExtensions registry key in revision 10768.

Nice :-) As you have a DWORD setting, you could implement more than
one of these schemes.

0: Filename with extension
1: With and without extension
2: Without extension

BTW if I may comment on the coding style there:
- while ((pos = sPartPath.Find('/', pos)) >= 0)
- {
- pos++;
+ int lastPos = 0;
+ for(int pos = 0; pos = sPartPath.Find('/',
lastPos) + 1; lastPos = pos)

That for (;;) loop is very concise, but I had to read it several times
to convince myself that it was doing (almost) the same as the more
obvious while loop that it replaces.

I don't normally read commit messages in such detail, but I was trying
to figure out which of the proposed options you had implemented ;-)
Keep up the good work.

Simon

-- 
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org