[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Bug during commit of not added files

From: Simon Large <simon.tortoisesvn_at_googlemail.com>
Date: 2007-09-12 21:24:48 CEST

On 12/09/2007, Stefan Küng <tortoisesvn@gmail.com> wrote:
> Tobias Schäfer wrote:
> > On Tuesday 11 September 2007 22:36:14 Simon Large wrote:
> >> If we are adding the directories, why can't we add them recursively?
> >
> > This mighty help in some cases, but I don't like the idea of changing the
> > behaviour and having bug reports which say "TortoiseSVN recursively added
> > my whole hard disk but I only wanted to do add the top level directory".
> >
> > That's why I prefer a warning when committing an unversioned directory. This
> > warning will not appear if the directory is already added: Maybe the user
> > is doing an in-place import. He either explicitly did not add the child
> > items when adding the directory or the child items were created after the
> > directory was added. But in this case those child items would be shown in
> > the commit dialog and checked by default - so no problem. Unless of course
> > the commit dialog had already been opened after the adding of the
> > directory.
> > Now it's getting complicated and the case is rather unlikely.
>
> And don't forget: all this will only happen if the setting "Recurse into
> unversioned folders" in Settings->Dialogs2 is deactivated.
> If that setting is activated, the user will also see all the unversioned
> files inside that unversioned folder.
>
> The settings is off by default to speed up the status fetching process
> for the commit dialog.

One other thought before putting this to bed. You could put an 'Add
recursively' in the context menu for unversioned folders, and have
Tobias' suggested warning. At least the user does not then have to
exit the dialog to add the files as well.

Simon

-- 
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Wed Sep 12 23:54:32 2007

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.