[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: Re: Commit dialog + Drag'n'drop

From: Lübbe Onken <l.onken_at_rac.de>
Date: 2007-08-31 11:05:04 CEST

Hi Tobias,

You wrote:

>> Isn't the commit dialog supposed to accept dragged files for commit
>> in general? Does it only accept versioned files?
>
> It did only accept the unversioned files if they were not already
> listed in the commit dialog.
>
> Fixed in revision 10454 so that the "svn add" also works if the files
> are already shown.

In my commit dialog I have "show unversioned files" unchecked, so the unversioned file was never listed in the dialog. According to your explanation, the commit dialog should already have accepted the file via drag & drop.

The explanation sounds a little weird to me, but I can confirm that it works now with the latest nightly. Is it possible that the file was already "invisibly" contained in the list control as unversioned and thus was never added?

I like the double negative logic in the comment:

---SNIP---
// just add all the items we get here.
// if the item was not unversioned, the add will fail but nothing
// more will happen.
---SNIP---

I hope you don't mind if I change 'was not unversioned' to 'is versioned' :)

Cheers
- Lübbe

--
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Fri Aug 31 11:02:16 2007

This is an archived mail posted to the TortoiseSVN Dev mailing list.