[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: TSVN and XnView shell extention don't play together nicely

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: 2007-07-27 18:19:57 CEST

Lorenz wrote:

>> Ok, now you're on my list: you made me uninstall TSVN!!!
>> :)
>
> Oh, damn! And I so had hoped the CD I sent you would prevent such
> incidences 8-)

:)

>> After trying to debug this problem, setting breakpoints, deactivating
>> parts of the TSVN context menu code, ... I finally uninstalled it
>> completely.
>> But: XnView still messes up the context menu.
>>
>> So, it has nothing to do with TSVN but with XnView. You can try and
>> report this problem to the XnView guys.
>> btw: I have another shell extension installed
>> (http://free.firmtools.com/shellextension/) which provides image
>> previews in the context menu, and that one works just fine.
>
> I agree with you then, that XnView has a part in the events, but as I
> don't see the effect with TSVN 1.4.4 there must have something changed
> in TSVN too.

Yes, the context menu has changed so that it now uses the native themed
UI of windows. And it doesn't use ownerdraw anymore. But it still works
correct.

> That you can't reproduce the effect may be due to an other shell
> extension that is using owner drawn (FirmTools ShellExtension in your
> case).

Well, maybe. But let's be honest here: if this happens even if TSVN is
uninstalled (whether it is due to another shell extension or due to some
(unknown to us) configuration doesn't matter), then the bug is clearly
in XnView.
Another indication that it's XnViews fault is that this only happens if
you right-click on an image where XnView provides a preview for. Since
context menu handlers are invoked for *all* files, the XnView handler is
also invoked for non-image files (but XnView then decides to do
nothing). Which means that this gets triggered by something XnView does
*while showing the preview*.

> I'm going to check that out when I find the time, but that may be not
> before 2007-08-06 as I'm on holidays next week.

Just enjoy your holidays. Bug checking doesn't count as holidays :)

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Fri Jul 27 18:18:43 2007

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.