Re: Revision Graph crashes if the log message is written in Japanese

masaru tsuchiyama wrote:
> I found a bug on Revision Graph.
> It crashes when showing the log message which is written in Japanese.
>
> The crash happens at the below code in CRevisionGraphWnd::OnToolTipNotify.
> if (rentry->tagNames.empty())
> {
> strTipText.Format(IDS_REVGRAPH_BOXTOOLTIP,
> rentry->revision,
> rentry->realPath.GetPath().c_str(),
> revisionInfo.GetAuthor(index),
> date,
> revisionInfo.GetComment(index).c_str());
> }
>
> At the time, revisionInfo.GetComment(index).c_str() is an endless string,
> It has no \0 termination.
>
> And I attach a repository dumpfile which can reproduce the crash.
> If you move the mouse cursor to revision 1, "Revision Graph" crashes.

Thanks for the report and the test repo.
I've tested with the latest version from trunk, and the crash doesn't
happen there anymore. But with your test repo I found another bug in
trunk which showed the log message in the wrong encoding.

If this crash is really serious for you, you can try a nightly build.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org