[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: Revision graph rewrite

From: Lübbe Onken <l.onken_at_rac.de>
Date: 2007-07-11 10:02:19 CEST

Hi Stefan^2

Just installed the nightly. The curves in the revision graph look really
good :)

Two quick observations:
- There was a repaint problem in the menu bar (windows below it shining
through), when I maximized/minimized the revision graph window for the first
time. Couldn't reproduce this.
- There is a problem when zooming in/out. The top left corner of the
magnified section moves away when zooming in/out. It doesn't stay centered
around the current view. It looks like you swapped +/-. The top left corner
moves down&right when zooming out instead of moving left&up.
- It looks like the leftmost "column" of nodes is missing from the preview
window. Or is it possible that the placement of the zoombox on the preview
window is wrong or that the bottom half of the nodes just doesn't get
painted (see RevGraphPreview)?
- When I "fit graph to window" and select a rectangle with the mouse, the
location of the first mouse click is used as the top/left corner of the zoom
window. Gives you funny results when you draw a rectangle from bottom right
to top left. Please use the top left corner of the selection rectangle :)

What is the default zoom factor and location of the first view of the graph?
The same as when the graph was viewed the last time? Or is it always
top/left, zoom 100%? At least in my case I rarely see a node when the graph
comes up. How about a heuristic like "make the latest node and 20/50/100
other nodes visible"?

Another suggestion: Try to keep the revision number readable as long as
possible. If the zoom factor is too small to display the revision number &
path, just display the revision number in a 8 point font at the top left of
(or over) the box. This can be done until the graph boxes are smaller than
the font height. (See RevGraphZoomed_1/2.png as an example)

Nice work!

- Lübbe

  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.net

To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org

Received on Wed Jul 11 10:01:51 2007

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.