Re: Bug Report: Crash with bugtraq properties

Simon Large wrote:
> On 10/07/07, Stefan Küng <tortoisesvn@gmail.com> wrote:
>> Adam Cabler wrote:
>> > I am trying to get clickable links for issue tracking in my commit
>> messages. I
>> > have set the bugtraq properties as follows:
>> >
>> > logregex [Ii]ssue AA-?(\d+)(,? ?AA-(\d+))*
>> > number true
>> > url http://jira:8080/browse/AA-%BUGID%
>> >
>> > When I enter a message that satisfies the regex, tortoise
>> consistently crashes
>> > on the first character that causes a match.
>>
>> Your regex is wrong. As the docs clearly state here:
>> http://tortoisesvn.net/docs/release/TortoiseSVN_en/tsvn-dug-bugtracker.html
>>
>>
>> "If only one expression is set, then the bare bug ID's must be matched
>> in the groups of the regex string. Example: [Ii]ssue(?:s)? #?(\d+)"
>>
>> In your case, you have three groups, not just two. And two of the groups
>> are repeated indefinitely.
>
> But it shouldn't crash, whatever is in the regex. It should just
> produce a non-match.

Well, the try-catch block should usually get rid of those, but the regex
lib calls some APIs to make sure its exceptions can't be caught :(

I've committed a fix for the crash in r10065.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org