[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: log cache assertion

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: 2007-07-06 21:58:01 CEST

Stefan.Fuhrmann@etas.de wrote:
> The bug at hand is difficult to describe (sorry for the complexity
> in the log caching but I think it is necessary):

Yes, I noticed that the cache is very complex. And you've done a
wonderful job there. But instead of explaining in detail every time a
bug is found why this happened, I suggest to simply explain the whole
thing in the comments.
Yes, I know I'm not the one who should complain about the lack of
comments - I'm guilty of the same crime. But it would really help if you
could add some comments explaining some of the classes there.

> * CStringDictionary stores unique strings and associates them with
> an ID. The log cache uses these containers to replace string data
> with simple integer data, i.e. it can operate on fixed-size numbers
> (indices, tokens) instead of variable-length character streams.

Where does it get the ID from, i.e., how is the unique ID generated?

I've started converting some of your comments to the proper Doxygen
format, which is also an opportunity for me to dig into your code a
little bit more. And I already found some classes which lack
documentation and which I don't really know what they are used for:

CLogBatchIteratorXXX : these classes seem to be not used. What are these

CDictionaryBasedTempPath is also not documented, but at least it is used.

The XML classes are AFAIK not used in TSVN but only in the test suite.
Should be maybe remove those from the library to save a little space?


   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Fri Jul 6 21:57:50 2007

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.