[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Threading problem in IconOverlay code

From: Jan Rysavy <jan.rysavy_at_altap.cz>
Date: 2007-06-28 12:23:30 CEST

Hi Stefan and Tomas,

> > - Change the global variables to be member variables of the COM object,
> > thus making them per-instance.
> This one is clearly to be prefered. g_filepath, for instance, is
> only used in IsMemberOf (I simply told VS to grep all files). Thus,
> it can safely be made a member variable. My impression is that this
> is true for most globals.

I think that if you store g_filepath to each COM object, it will
lose its "caching" sense (other COM objects called for the same
filename need to use it).

So I think that storing g_filepath (and others) to TLS is the best
solution to this problem. Or you can leave it global, but you must
access to these variables only in critical section.

We (ALTAP) have spent three days on this problem (reproduce and
identify it), could you please fix it? It will definetely make
TSVN more stable in Windows Explorer and other hosts.

Best regards

Jan Rysavy
Czech Republic
Tel.: +420 487 725 132

To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Thu Jun 28 12:23:45 2007

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.