Re: [PATCH] Off by one error in SetRevisionIndex

Tomas Kopal <Tomas.Kopal@altap.cz> wrote:

> I started using TortoiseSVN recently, but it keeps crashing on me. So
> grabbed the sources and went looking for problems. So, here is the first
> one I found :-).

Cool! Thanks for the patch. You stumbled accross some edge-case here.
Committed as r9892.

> Please, someone with more knowledge of the code, check the lower bound
> growing too, I think it may suffer from the same problem.

That part seems to be o.k. (since me being the author, this
verdict does not actually count ;).

BTW: Code review is *VERY* wellcome, especially for the
LogCache sub-folder. There are some parts where off-by-one
and similar problems will be hard to detect.

-- Stefan.
Received on Mon Jun 25 13:26:10 2007