Re: Partly revert revision 6174?

Tobias Schäfer wrote:
> Hi Stefan,
>
> I would like to revert the part of revision 6174 which contains the
> following diff:
> --- C:/Development/SVN/TortoiseSVN/src/TortoiseBlame/TortoiseBlame.cpp
> (revision 6173)
> +++ C:/Development/SVN/TortoiseSVN/src/TortoiseBlame/TortoiseBlame.cpp
> (revision 6174)
> @@ -1120,6 +1121,9 @@
> }
> break;
> case WM_RBUTTONDOWN:
> + if (app.m_selectedrev >= 0)
> + break;
> + // fall through
> case WM_LBUTTONDOWN:
> {
> int y = ((int)(short)HIWORD(lParam));
>
> I'm currently implementing the rest of issue 343:
>
> If the user selects a revision with the left button and then clicks on a
> different revision with the right button, TortoiseBlame will call "Blame
> previous revision" for the revision selected with the left button. This is
> wrong as selecting with the right button should also be possible.
>
> The log message of revision 6174 says: "Only selected the revision on
> right-click if no other revision is selected. Do not deselect an already
> selected revision." which is exactly what it does but in my opinion this
> behaviour is wrong.
>
> May I revert this change?

Sure you can revert this.
If you need to execute an action on a selected item through a
right-click, then that right-click should select the item.
I think that change was made because there weren't any actions on
selected entries on a right-click previously.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org