Re: [PATCH] Create Patch for multiple files

Tobias Schäfer wrote:
> Hi,
>
> if multiple files are selected in a directory and these files have filenames
> which start with a common prefix, then "Create Patch" fails.
>
> Example in the sources of TSVN:
>
> /command:createpatch /path:"C:
> \Development\SVN\TortoiseSVN\src\TortoiseProc\LogDlg.cpp*C:
> \Development\SVN\TortoiseSVN\src\TortoiseProc\LogDlg.h" /notempfile
>
> This would currently determine
> C:\Development\SVN\TortoiseSVN\src\TortoiseProc\LogDlg as the common
> directory which is obviously wrong.
>
> The attached patch fixes this. All tests in CTSVNPath pass, but please
> review.
>
> Should this be merged to 1.4.x?

Patch looks good!
Can you also add a test for this case?

And yes, you should merge it back to 1.4.x.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org