Re: A couple TortoiseIDiff code questions

On 2/12/07, Rick Yorgason <rick@firefang.com> wrote:
> Hey guys,
>
> I'm working on extracting the images in IDiff into plain RGBA data so we
> can support transparent images and different blending modes. This seems
> to be working alright, but it's a pretty big refactoring for CPicture.
>
> This lead me to notice a couple things in the current code that I'm
> unsure about. The first is this line:
>
> FreeResource(hGlobal); // 16Bit Windows Needs This (32Bit - Automatic
> Release)
>
> Does Tortoise actually support 16bit versions of Windows? Is this line
> necessary at all?

You can safely remove that line.

> The other thing I noticed is that the FreeImage dll isn't loaded unless
> GDI+ exists. Was this a mistake, or is there some dependency I'm
> unaware of?

I think that's a bug.

Stefan

-- 
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org