[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: TortoiseIDiff alpha undo/toggle

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: 2007-02-02 21:24:27 CET

Rick Yorgason wrote:
> Stefan Küng wrote:
>> Just trying out your patch. Here's what I noticed:
>> when toggling, it toggles between an alpha value of 255 and the
>> previously selected one. Then it toggles back. But what I like to have
>> it do is to toggle between 0 - set value - 255 (a three state toggle).
>> Would you be ok if I change your patch that way?
>> Stefan
> Actually, what it does is toggle between the last selected value and the
> currently selected value -- basically like a one-step undo -- so if you
> set it to 128, then moved it to 200, it will toggle back and forth
> between those two values. I think this is more useful, intuitive and
> flexible than the three-way toggle.

Ok, I think I get it now. You first need to have used two different
alpha values before you can toggle between them.

I think to make this work the way users know how to use this would be to
use a slider control where you can mark two positions, not just one.
Maybe that would be an option?

> I think you're being mislead because the 'undo' state is initially set
> to 255. That wasn't intended, but I was torn on whether or not to fix
> it. On one hand, it's less intuitive, since it's not plainly obvious
> that it works like an undo button, but on the other hand, its initial
> state is immediately useful before adjusting the slider.
> I'm open to suggestions though.

I think I'll commit your patch now with my changes so that it toggles
between 0 - last used value - 255.
But of course, feel free to change it again, but then you should do it
in a way that's more clear to the user.

Not sure if the slider control can show two sliders to mark a range, but
if it can you might want to use that?


   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Fri Feb 2 21:24:42 2007

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.