Re: [patch] Remove used code in SVN::logReceiver()

Daniel Rall wrote:
> [[[
> Remove used code.
          ^^^^

??? :-)

> * src/SVN/SVN.cpp
> (SVN::logReceiver): Remove unnecessary "if" statement around log
> notification, and redundant "return error" statement.
> ]]]
>
>
> ------------------------------------------------------------------------
>
> Index: src/SVN/SVN.cpp
> ===================================================================
> --- src/SVN/SVN.cpp (revision 8244)
> +++ src/SVN/SVN.cpp (working copy)
> @@ -1214,10 +1214,7 @@
> SVN_ERR (svn->cancel(baton));
> #pragma warning(pop)
>
> - if (svn->Log(rev, author_native, date_native, msg_native, arChangedPaths, time_temp, filechanges, copies, actions))
> - {
> - return error;
> - }
> + svn->Log(rev, author_native, date_native, msg_native, arChangedPaths, time_temp, filechanges, copies, actions);
> return error;

We can't remove that code: the Log() method is virtual, and other
classes have to override it to actually get the log data. Sure, right
now no other class/dialog returns an error, but I like to have the
option to maybe do that later (e.g. out-of-memory errors, other errors
which might occur while trying to use the log data, ...)

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org