Re: [PATCH] issue #97: items are not always checked when dialog reopens

Tobias Schäfer wrote:

>> That's an edge case we now live with since the beginning of TSVN. I
>> don't think it's that dangerous.
>> The problem is that if we don't commit recursively if everything is
>> checked, then committing deleted folders won't work.
>
> We could change the logic to only do a recursive commit if at least one
> deleted folder is selected and fall back to non-recursive in all other
> cases. That would fix the error in my scenario and make it less unlikely to
> run into the edge case.

The problem we face with non-recursive commits is that Subversion
doesn't really use those. If there are bugs with non-recursive commits,
they won't be detected until I get the crashreports (happened more than
one time before already with non-recursive commits).
I really like to keep the commits recursive whenever possible.

btw: the same edge case happens with the command line client. If the
user does an:

svn st

then checks the output which seem ok. He then goes on to do an

svn ci -m ""

but in between the two commands, another file got modified that one will
also be committed.

I think we should just leave it as it is now.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org