[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] issue #97: items are not always checked when dialog reopens

From: Tobias Schäfer <tobiasschaefer_at_gmx.de>
Date: 2006-11-26 09:10:33 CET

Hi,

TSVN doesn't behave like I would like it to in the following scenario:

Call commit on a directory which contains a modified file which is out of
date. All other files in the directory should be unmodified, so that you do
not need to uncheck any items. This will make TortoiseSVN do a recursive
commit on the directory.
After confirming the commit dialog you see that the file is out of date and
the commit dialog re-opens. So far so good, but you will notice that the
previously checked state of the file is not restored. The attached patch
fixes this.

Ok to commit and merge to 1.4.x? I'm asking this because when fixing this
issue I noticed the following which is kind of related.

Same scenario as above, but the file is up to date. As soon as the commit
dialog opens for the first time modify a further file in the directory. Do
*not* refresh the commit dialog so it still only lists one modifed file.
Now call commit and you will notice two files being sent to the server. The
reason for this: TortoiseSVN does a recursive commit on the directory
because no files where unchecked but unfortunately a file was modified
later which then gets commited.
A solution would be to rescan the directory before actually committing but
this would never be perfect because the files might be changed after the
rescan has taken place and before the subversion library has taken care of
the commit. Should we live with this corner case?

Tobias

-- 
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.net


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org

Received on Sun Nov 26 09:10:58 2006

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.