Re: [PATCH] "Show diffences" when selecting multiple revisions in the log dialog

Tobias Schäfer wrote:
> hi,
>
> the following patch fixes two bugs which occur if multiple revisions are
> selected in the log dialog
>
> 1. If two revisions are selected "Show diffences" uses the two selected
> revision numbers. Correct would be one revision below the lower revision
> number.
> 2. if more than two revisions are selected no more than two selected
> revisions are used to calculate the revision range.
>
> Both bugs are fixed in this patch. I intend to commit them in two revisions
> and merge it into 1.4.x.
>
> Please review: Is that min(...) I introduced really needed or are the
> revision numbers always decreasing while iterating. In this case the
> min(...) could be removed.

Don't remove it!
It's not defined in which order those entries are shown in the list
control (sorting).

> Should I wait for my commit after 1.4.1 is released?

Just commit it now.

> + }
> }
> POSITION pos = m_ChangedFileListCtrl.GetFirstSelectedItemPosition();
> while (pos)

while you're at it: please remove the
POSITION pos = ...
and change it to
pos = ...

Otherwise there's two POSITION pos variables - not good style (I know,
my fault).

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org