Re: [PATCH] Remove single entries from combo boxes

Tobias Schäfer wrote:

> currently the URLs shown in combo boxes are stored in the registry. The
> stored URLs can be reset in the settings dialog under "Saved Data". This
> removes all URLs of all repositories.
>
> This patch allows the deletion of *single* URLs without manually editing the
> registry: just select any URL and press Shift-Delete.
>
> I would commit this without asking, but I have one usability question :-)
>
> Should it be possible to delete entries only if the combo box is in the
> dropped state, i.e. it is open or should it always be possible. I prefer to
> always allow the deletion but your feedback ist welcome.
> btw, in the Internet Explorer this is only possible in the dropped state.

I would tend to agree with you, but then there's the urge to keep the UI
consistent with how Windows works (IE is part of windows, as MS defended
in courts).
Just do it as you like.

Some comments about the patch:

> if (pMsg->message == WM_KEYDOWN)
> {
> + bool bShift = !!(GetAsyncKeyState(VK_SHIFT) & 0x8000);

Why GetAsyncKeyState? I think GetKeyState() would be better here.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org