Some problems with "Revert changes from this revision"

I found some problems with "Revert changes from this revision" for
changed paths in LogDlg. I'm using TortoiseSVN 1.4.0 r7501.

* A "delete" action can't be reverted.
This seems to be introduced by r7021. Absence of a deleted file can
occur normally. Then it shouldn't be an error.

* If the target of a LogDlg has non-ascii characters in its URL, any
   action can't be reverted.
This is more complicated. Non-ascii characters in changed paths doesn't
cause this problem. The target which is selected to launch LogDlg is the
root of this problem. I currently suspects GetURLFromPath().
Because I think SVN::get_url_from_target() returns a UTF-8 URL, the
return value "CString(URL)" in GetURLFromPath() seems to cause wrong
(system default encoding to Unicode) conversion instead of UTF-8 to
Unicode conversion. But if it is wrong, many use of GetURLFromPath()
should cause similer problems.

I don't have enough time to write a patch now. Could someone please
look into this?

--
k_satoda
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org