SV: Re: TortoiseIDiff suggestions

>> http://issues.tortoisesvn.net/?do=details&id=300
> OK, can something be done about a generic interface for
> producing this "combined mode" image? Something like
>
> void GenerateCombinedImage(const Image& left, const Image& right,
> const Rectangle& rectToProcess, const Params& params, Image& dest);

I'd suggest creating some kind of OO interface there. Let's have an
abstract base class "ImageComparer" that has a pure virtual method
GenerateCombinedImage. It would look something like:

void GenerateCombinedImage(const Image& left, const Image& right, Image&
dest);

Subclasses would then implement that method to do different kinds of
comparisons. That way it will be easy to separate the different
implementations, but still have common functionality (if any) in the
base class. If the necessity for parameters or configuration arises,
this could be implemented with an pure virtual Configure()-method in the
base class that the subclasses must implement to either return null or
provide the user with a dialog to configure the comparer.

If no-one objects I'll add something along these lines to the issue.

Hans-Emil

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Tue Sep 26 09:04:12 2006