Re: issue #137

Joseph Galbraith wrote:
> Hmmm... I though that when we looked for a TSVN property,
> we traversed the directory tree to the top of the wc looking
> for the property, and stopped on the first directory that has it?
>
> If we applied that logic, and the user did a commit
> in c:\wc\x\y\z, we'd look in c:\wc\x\y\z first, then
> c:\wc\x\y, then c:\wc\x and so on.
>
> If the tsvn:my-hook property was set to a/b/c.pl on
> c:\wc, then we'd use c:\wc as the default path and
> a/b/c.pl as the relative path, leading to:
> c:\wc\a\b\c.pl as the hook-script.
>
> Would this work? Or am I majorly confused?

Yes, of course that would work. But you know that we suggest to users to
set the project properties on *all* folders in the working copy, because
you can't be sure from which url they check out the working copy. For
example, many translators don't have TSVN checked out from trunk, but
only the /Languages folder.
So as I said, you'd have to also set the property on that folder, which
then has a different relative path (in your case "../a/b/c.pl").
And that's what I meant with users complaining about setting those
properties on all folders - you can't just set the property recursively
like all other props, you must add them individually on each folder (now
imagine a user with a working copy consisting of 10 levels of folders...).

> Another alternative would be to use the global config
> to give hook-scripts names:
>
> my-hook = c:\bin\xyzzy
>
> and then have the property refer to 'my-hook' instead
> of c:\bin\xyzzy
>
> That does require every client to be configured-- but
> then again, I'm not sure that is a bad thing. That
> would definitely reduce the security concerns if the
> hook had to be listed in the global config and what was
> actually run was controlled there rather than in the
> repository.

I don't like the idea of a global config option which really is not
global but per-project.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org