Re: issue #137

Joseph Galbraith wrote:
> Stefan Küng wrote:
>> Hi,
>>
>> I'm currently trying to implement issue #137:
>> http://tortoisesvn.net/issues/?do=details&id=137
>>
>> But now I have some problems where I hope you can help me out with
>> some ideas:
>>
>> If the hook scripts are configured via project properties (i.e. like
>> the bugtraq properties), how should we define the path to the script?
>> To avoid security issues, I want to force the scripts to be inside the
>> working copy. But with project properties, you can't define an
>> absolute path to a script, and relative paths don't really work
>> because the user can start TortoiseProc from any directory.
>
> You could say that relative is relative to the folder that has
> the property set rather than relative to the current directory
> of TortoiseProc.

Ok, but if we do that, then users will (rightfully) complain that it is
a real pain in the ass to set the properties on all folders - because
all folders will have different relative paths. So that's not really an
option.

>> If however we configure the hook scripts with e.g. a global config
>> file or in the settings dialog, then they won't be 'project only' (we
>> could find a way around that, but it would be *very ugly* UI wise),
>> and then each user would have to configure them him/herself.
>>
>> So, what's the best way to go here? Any ideas on how to specify a path
>> to the scripts when using project properties?
>
> Even forcing the hook script to be inside the WC still
> seems dangerous to me-- what if someone hacked a
> repository and committed both the property and a
> malicous script.
>
> I think probably, rather than insisting that the script
> be in the working copy, the user should be prompted before
> the script is run, something like this:
>
> There is a hook-script configured for this action, which
> may provide increased functionality or improved error
> handling for this repository.
>
> Hook-scripts can modify your system in undesired ways; one
> should use caution about allowing hook scripts to run,
> especially from a public repository.
>
> _Always run this script_ _Run script_ _Don't Run_
>
> (And there should probably be a global option to say don't
> ever run hooks.)

Good idea.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org